Skip to content

Commit

Permalink
Wrong port id in fip-show of floatingip assigned to virtual-ip
Browse files Browse the repository at this point in the history
In case of floating ip on the Virtual-ip, svc-monitor will link floating ip to
"right" interface of service VMs launched by ha-proxy service instance.

Ignore such VMI while walking the vmi_ref from floatingip object.
This is done based on the service interface type of the interface.
Right interface of the service instance will have this property value set to "right"

(cherry picked from commit 96e3d718666249b38c7546c9241e75d87369bb9f
of contrail-controller)

Change-Id: Ia4ed307c4a5691411bd352a34e26c167c299f118
Closes-bug: #1482277
  • Loading branch information
numansiddique committed Aug 26, 2015
1 parent 3d8dbd2 commit 9fca28b
Showing 1 changed file with 9 additions and 0 deletions.
Expand Up @@ -88,6 +88,15 @@ def _fip_obj_to_neutron_dict(self, fip_obj, fields=None):
for vmi_ref in vmi_refs or []:
try:
vmi_obj = vmi_get_handler.get_vmi_obj(vmi_ref['uuid'])

# In case of floating ip on the Virtual-ip, svc-monitor will
# link floating ip to "right" interface of service VMs
# launched by ha-proxy service instance. Skip them
props = vmi_obj.get_virtual_machine_interface_properties()
if props:
interface_type = props.get_service_interface_type()
if interface_type == "right":
continue
port_id = vmi_ref['uuid']
break
except vnc_exc.NoIdError:
Expand Down

0 comments on commit 9fca28b

Please sign in to comment.