-
Notifications
You must be signed in to change notification settings - Fork 390
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix Vrouter Agent crash @ update flow handle
Issue: ------ Even though Hash id is part of the key for ksync flow entry, we do allow change of hash id to -1 when other ksync entry for the same flow ends up receiving same flow handle to handle two entries with same key. however if there was a pending response(Add/Change Ack) from vrouter we will end up processing the ack as a index allocation from value -1 to flow handle for delete ksync entry. This can end up acquiring the index from the active entry and cause invalid state for ksync flow entry, resulting in crash. Fix: ---- Save the last vrouter hash id (hash id used while sending message to vrouter) and compare the ack/response against this hash id to evaluate if response has a new index allocation. Conflicts: src/vnsw/agent/pkt/test/test_flow_mgr_instances.cc Closes-Bug: 1613553 Change-Id: I21a12fbd5684de871eabf5cd6dd1568c0a9d6c52 (cherry picked from commit 2a743d7)
- Loading branch information
Prabhjot Singh Sethi
committed
Aug 22, 2016
1 parent
9416391
commit f05357f
Showing
3 changed files
with
23 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters