Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make BGPaaS config processing more defensive
Consider the following scenario: Peer1 has source port p1 Peer2 has source port p2 Configuration for Peer1 is changed to have port p2 i.e. both Peer1 and Peer2 have port p2. Existing implementation removes Peer2 from it's port to peer mapping table under the assumption that the port for Peer2 will soon change to a new value. However, if the port for Peer1 is now changed back to p1, the port to peer mapping table no longer has an entry that maps p2 to Peer2. Fix by using a multimap instead of map to maintain port to peer mapping. It's expected that duplicate port values may only be seen in transient situations when the ST is being restarted and/or has a bug. This change lets the CN get to a sane configuration once any configuration issues are fixed. Change-Id: If48e4c9648d7ea5a8a121c1a46e7f10ce7451936 Closes-Bug: 1669871
- Loading branch information
Nischal Sheth
committed
Mar 5, 2017
1 parent
f3fa537
commit aa776f8
Showing
7 changed files
with
122 additions
and
73 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters