Wrong port id in floatingip-show of floatingip assigned to virtual-ip…

… port

In case of floating ip on the Virtual-ip, svc-monitor will link floating ip to
"right" interface of service VMs launched by ha-proxy service instance.

Ignore such VMI while walking the vmi_ref from floatingip object.
This is done based on the service interface type of the interface.
Right interface of the service instance will have this property value set to "right"

Change-Id: Icb8cc874da4d18c4def631566fc7e2257f2f5fe4
Closes-bug: #1482277

src/config/vnc_openstack/vnc_openstack/neutron_plugin_db.py

@@ -1628,6 +1628,16 @@ def _floatingip_vnc_to_neutron(self, fip_obj):
                 try:
                     port_obj = self._virtual_machine_interface_read(
                         port_id=port_ref['uuid'])
+
+                    # In case of floating ip on the Virtual-ip, svc-monitor will
+                    # link floating ip to "right" interface of service VMs
+                    # launched by ha-proxy service instance. Skip them
+                    props = port_obj.get_virtual_machine_interface_properties()
+                    if props:
+                        interface_type = props.get_service_interface_type()
+                        if interface_type == "right":
+                            continue
+
                     port_id = port_ref['uuid']
                     break
                 except NoIdError:

src/config/vnc_openstack/vnc_openstack/tests/test_vnc_plugin_db.py

@@ -78,6 +78,9 @@ def test_floating_show_router_id(self):
         dbi = MockDbInterface()
         vmi_obj = None
 
+        def fake_virtual_machine_interface_properties():
+            return None
+
         def fake_virtual_machine_read(id, fq_name=None, fields=None,
                                       parent_id=None):
             if id == 'fip_port_uuid1':
@@ -87,6 +90,8 @@ def fake_virtual_machine_read(id, fq_name=None, fields=None,
             elif id == 'router_port_uuid':
                 net_uuid = 'match_vn_uuid'
             return flexmock(uuid=id,
+                            get_virtual_machine_interface_properties=\
+                            fake_virtual_machine_interface_properties,
                             get_virtual_network_refs=\
                             lambda: [{'uuid': net_uuid}])