Do not refer to instance variables in constructor parameters initiali…

…zation Tools like valgrind does not like it.. IIRC, an issue was also seen (crash) once in production/test environment Change-Id: I3123acfb25a28fe8acd5d828adca1150101783b0 Closes-Bug: 1649415
Juniper · Dec 12, 2016 · 89b71f0 · 89b71f0
1 parent 3f0bd05
commit 89b71f0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/bgp/bgp_peer.cc b/src/bgp/bgp_peer.cc
@@ -420,15 +420,15 @@ BgpPeer::BgpPeer(BgpServer *server, RoutingInstance *instance,
                          BgpProto::IBGP : BgpProto::EBGP),
           state_machine_(BgpObjectFactory::Create<StateMachine>(this)),
           peer_close_(new BgpPeerClose(this)),
-          close_manager_(BgpObjectFactory::Create<PeerCloseManager>(
-                      peer_close_.get())),
           peer_stats_(new PeerStats(this)),
           deleter_(new DeleteActor(this)),
           instance_delete_ref_(this, instance ? instance->deleter() : NULL),
           flap_count_(0),
           total_flap_count_(0),
           last_flap_(0),
           inuse_authkey_type_(AuthenticationData::NIL) {
+    close_manager_.reset(
+        BgpObjectFactory::Create<PeerCloseManager>(peer_close_.get()));
     ostringstream oss1;
     oss1 << peer_key_.endpoint.address();
     if (peer_key_.endpoint.port() != BgpConfigManager::kDefaultPort)

diff --git a/src/bgp/bgp_xmpp_channel.cc b/src/bgp/bgp_xmpp_channel.cc
@@ -464,10 +464,8 @@ BgpXmppChannel::BgpXmppChannel(XmppChannel *channel,
       bgp_server_(bgp_server),
       peer_(new XmppPeer(bgp_server, this)),
       peer_close_(new BgpXmppPeerClose(this)),
-      close_manager_(BgpObjectFactory::Create<PeerCloseManager>(
-                         peer_close_.get())),
       peer_stats_(new PeerStats(this)),
-      bgp_policy_(peer_->PeerType(), RibExportPolicy::XMPP, -1, 0),
+      bgp_policy_(BgpProto::XMPP, RibExportPolicy::XMPP, -1, 0),
       manager_(manager),
       delete_in_progress_(false),
       deleted_(false),
@@ -484,6 +482,8 @@ BgpXmppChannel::BgpXmppChannel(XmppChannel *channel,
             channel->GetTaskInstance(),
             boost::bind(&BgpXmppChannel::MembershipResponseHandler, this, _1)),
       lb_mgr_(new LabelBlockManager()) {
+    close_manager_.reset(
+        BgpObjectFactory::Create<PeerCloseManager>(peer_close_.get()));
     if (bgp_server) {
         eor_receive_timer_ =
             TimerManager::CreateTimer(*bgp_server->ioservice(),