Skip to content

Commit

Permalink
Don't send XmppPeerInfo UVE on table subscribe/unsubscribe
Browse files Browse the repository at this point in the history
The UVE has a list of tables to which the xmpp peer is registered.
Building and sending the entire list of tables each time the peer
subscribes and unsubscribes to a table is very expensive.

Do not send the UVE for the time being. Will resume sending the UVE
after new infra to make incremental updates to a list is available.

Change-Id: I1905755f665432e5cfc0229099e88bcc3bbf6b4c
Partial-Bug: 1456284
  • Loading branch information
Nischal Sheth committed Jun 2, 2015
1 parent af7ce2b commit 7bb8387
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions src/bgp/bgp_xmpp_channel.cc
Expand Up @@ -1901,18 +1901,6 @@ bool BgpXmppChannel::MembershipResponseHandler(string table_name) {

// Erase all elements for the table
defer_q_.erase(vrf_n_table);

vector<string> registered_tables;
mgr->FillRegisteredTable(peer_.get(), &registered_tables);
if (registered_tables.empty())
return true;

XmppPeerInfoData peer_info;
peer_info.set_name(peer_->ToUVEKey());
peer_info.set_routing_tables(registered_tables);
peer_info.set_send_state("in sync");
XMPPPeerInfo::Send(peer_info);

return true;
}

Expand Down

0 comments on commit 7bb8387

Please sign in to comment.