Use vm_name to delete the VM object

Schema transformer was incorrecty using si_name to delete VM object. It should
use vm_name. Because of this, stale VM objects remain in schema transformer
local memory and so, if SI is created again, it thinks the VM exists but no VMIs
exist and hence service chain is not created.

This is partial fix because we still do not break service chain when SI is deleted.

Change-Id: I4458352e3af0feeb1f68c57920b6875991cfac81
Partial-Bug: 1499125
(cherry picked from commit b5fe2fa)

src/config/schema-transformer/to_bgp.py

@@ -3136,7 +3136,7 @@ def add_virtual_machine_service_instance(self, idents, meta):
     def delete_virtual_machine_service_instance(self, idents, meta):
         vm_name = idents['virtual-machine']
         si_name = idents['service-instance']
-        vm = VirtualMachineST.delete(si_name)
+        vm = VirtualMachineST.delete(vm_name)
         for sc in ServiceChain._dict.values():
             if si_name in sc.service_list:
                 if VirtualNetworkST.get(sc.left_vn) is not None: