* Copy SG and community id to ecmp path from local path

If SG, community or tunnel map changes for a path copy that
updated list to ecmp path.
Test case for same.

(cherry picked from commit 5e5dae858cc944cd7b4247b9d18d34d27bc30f19)
Closes-bug:#1549541
Change-Id: If6db411fa4f977fa82741b5eaad1f2b926c60684

src/vnsw/agent/oper/inet_unicast_route.cc

@@ -352,40 +352,12 @@ bool InetUnicastRouteEntry::ModifyEcmpPath(const IpAddress &dest_addr,
         ret = true;
     }
 
-    path->set_tunnel_bmap(tunnel_bmap);
-    TunnelType::Type new_tunnel_type =
-        TunnelType::ComputeType(path->tunnel_bmap());
-    if (path->tunnel_type() != new_tunnel_type) {
-        path->set_tunnel_type(new_tunnel_type);
-        ret = true;
-    }
-
-    SecurityGroupList path_sg_list;
-    path_sg_list = path->sg_list();
-    if (path_sg_list != sg_list) {
-        path->set_sg_list(sg_list);
-        ret = true;
-    }
-
-    CommunityList path_communities;
-    path_communities = path->communities();
-    if (path_communities != communities) {
-        path->set_communities(communities);
-        ret = true;
-    }
-
-    if (path_preference != path->path_preference()) {
-        path->set_path_preference(path_preference);
-        ret = true;
-    }
+    ret = SyncEcmpPath(path, sg_list, communities, path_preference,
+                       tunnel_bmap, ecmp_load_balance);
 
     path->set_dest_vn_list(vn_list);
     ret = true;
     path->set_unresolved(false);
-    if (path->ecmp_load_balance() != ecmp_load_balance) {
-        path->set_ecmp_load_balance(ecmp_load_balance);
-        ret = true;
-    }
 
     if (path->ChangeNH(agent, nh) == true)
         ret = true;
@@ -571,6 +543,53 @@ bool InetUnicastRouteEntry::ReComputePathDeletion(AgentPath *path) {
     return EcmpDeletePath(path);
 }
 
+bool InetUnicastRouteEntry::SyncEcmpPath(AgentPath *path,
+                                         const SecurityGroupList sg_list,
+                                         const CommunityList &communities,
+                                         const PathPreference &path_preference,
+                                         TunnelType::TypeBmap tunnel_bmap,
+                                         const EcmpLoadBalance
+                                         &ecmp_load_balance) {
+    if (!path) {
+        return false;
+    }
+
+    bool ret = false;
+    path->set_tunnel_bmap(tunnel_bmap);
+    TunnelType::Type new_tunnel_type =
+        TunnelType::ComputeType(path->tunnel_bmap());
+    if (path->tunnel_type() != new_tunnel_type) {
+        path->set_tunnel_type(new_tunnel_type);
+        ret = true;
+    }
+
+    SecurityGroupList path_sg_list;
+    path_sg_list = path->sg_list();
+    if (path_sg_list != sg_list) {
+        path->set_sg_list(sg_list);
+        ret = true;
+    }
+
+    CommunityList path_communities;
+    path_communities = path->communities();
+    if (path_communities != communities) {
+        path->set_communities(communities);
+        ret = true;
+    }
+
+    if (path_preference != path->path_preference()) {
+        path->set_path_preference(path_preference);
+        ret = true;
+    }
+
+    if (path->ecmp_load_balance() != ecmp_load_balance) {
+        path->set_ecmp_load_balance(ecmp_load_balance);
+        ret = true;
+    }
+
+    return ret;
+}
+
 // Handle add/update of a path in route. 
 // If there are more than one path of type LOCAL_VM_PORT_PEER, creates/updates
 // Composite-NH for them
@@ -625,14 +644,24 @@ bool InetUnicastRouteEntry::EcmpAddPath(AgentPath *path) {
         return false;
     }
 
+    bool ret = false;
     if (count == 2 && ecmp == NULL) {
         // This is second path being added, make ECMP 
         AllocateEcmpPath(agent, vm_port_path, path);
+        ret = true;
     } else if (count > 2) {
         // ECMP already present, add/update Component-NH for the path
         AppendEcmpPath(agent, path);
+        ret = true;
+    } else if (ecmp) {
+        AgentPath *ecmp_path = FindPath(agent->ecmp_peer());
+        ret = SyncEcmpPath(ecmp_path, path->sg_list(),
+                           path->communities(), path->path_preference(),
+                           path->tunnel_bmap(),
+                           path->ecmp_load_balance());
     }
-    return true;
+
+    return ret;
 }
 
 void InetUnicastRouteEntry::AppendEcmpPath(Agent *agent,

src/vnsw/agent/oper/inet_unicast_route.h

@@ -88,6 +88,11 @@ class InetUnicastRouteEntry : public AgentRoute {
                                DBRequest &nh_req,
                                Agent* agent,
                                AgentPath *path);
+    static bool SyncEcmpPath(AgentPath *path, SecurityGroupList sg_list,
+                             const CommunityList &communities,
+                             const PathPreference &path_preference,
+                             TunnelType::TypeBmap tunnel_bmap,
+                             const EcmpLoadBalance &ecmp_ecmp_load_balance);
 
     const IpAddress &addr() const { return addr_; }
     void set_addr(IpAddress addr) { addr_ = addr; };