Skip to content

Commit

Permalink
Provide hints for flags to be configured in respective daemon .conf f…
Browse files Browse the repository at this point in the history
…iles.

Change-Id: Id378f09eaf6efcaa4b3ea6aaecbbcbb89f879003
Closes-Bug:1522597
  • Loading branch information
nipak committed Mar 10, 2016
1 parent 86858f2 commit 474e678
Show file tree
Hide file tree
Showing 6 changed files with 36 additions and 4 deletions.
4 changes: 4 additions & 0 deletions src/control-node/contrail-control.conf
Expand Up @@ -19,6 +19,10 @@ log_file=/var/log/contrail/contrail-control.log
log_level=SYS_NOTICE
log_local=1
# test_mode=0
# xmpp_auth_enable=0
# xmpp_server_cert=/etc/contrail/ssl/certs/server.pem
# xmpp_server_key=/etc/contrail/ssl/private/server-privkey.pem
# xmpp_ca_cert=/etc/contrail/ssl/certs/ca-cert.pem
# xmpp_server_port=5269

# Sandesh send rate limit can be used to throttle system logs transmitted per
Expand Down
16 changes: 12 additions & 4 deletions src/control-node/test/options_test.cc
Expand Up @@ -213,8 +213,12 @@ TEST_F(OptionsTest, CustomConfigFile) {
"log_files_count=20\n"
"log_file_size=1024\n"
"log_level=SYS_DEBUG\n"
"log_local=1\n"
"test_mode=1\n"
"log_local=false\n"
"test_mode=0\n"
"xmpp_auth_enable=true\n"
"xmpp_server_cert=/etc/server.pem\n"
"xmpp_server_key=/etc/server.key\n"
"xmpp_ca_cert=/etc/ca-cert.pem\n"
"xmpp_server_port=100\n"
"sandesh_send_rate_limit=5\n"
"\n"
Expand Down Expand Up @@ -264,13 +268,17 @@ TEST_F(OptionsTest, CustomConfigFile) {
EXPECT_EQ(options_.log_files_count(), 20);
EXPECT_EQ(options_.log_file_size(), 1024);
EXPECT_EQ(options_.log_level(), "SYS_DEBUG");
EXPECT_EQ(options_.log_local(), true);
EXPECT_EQ(options_.log_local(), false);
EXPECT_EQ(options_.ifmap_server_url(), "https://127.0.0.1:100");
EXPECT_EQ(options_.ifmap_password(), "test-password");
EXPECT_EQ(options_.ifmap_user(), "test-user");
EXPECT_EQ(options_.ifmap_certs_store(), "test-store");
EXPECT_EQ(options_.xmpp_port(), 100);
EXPECT_EQ(options_.test_mode(), true);
EXPECT_EQ(options_.test_mode(), false);
EXPECT_EQ(options_.xmpp_auth_enabled(), true);
EXPECT_EQ(options_.xmpp_server_cert(), "/etc/server.pem");
EXPECT_EQ(options_.xmpp_server_key(), "/etc/server.key");
EXPECT_EQ(options_.xmpp_ca_cert(), "/etc/ca-cert.pem");
EXPECT_EQ(options_.sandesh_send_rate_limit(), 5);
}

Expand Down
1 change: 1 addition & 0 deletions src/dns/cmn/dns_options.cc
Expand Up @@ -290,4 +290,5 @@ void Options::Process(int argc, char *argv[],
GetOptValue<bool>(var_map, xmpp_auth_enable_, "DEFAULT.xmpp_dns_auth_enable");
GetOptValue<string>(var_map, xmpp_server_cert_, "DEFAULT.xmpp_server_cert");
GetOptValue<string>(var_map, xmpp_server_key_, "DEFAULT.xmpp_server_key");
GetOptValue<string>(var_map, xmpp_ca_cert_, "DEFAULT.xmpp_ca_cert");
}
4 changes: 4 additions & 0 deletions src/dns/contrail-dns.conf
Expand Up @@ -24,6 +24,10 @@ log_level=SYS_NOTICE
log_local=1
# test_mode=0
# log_property_file= # log4cplus property file
# xmpp_dns_auth_enable=0
# xmpp_server_cert=/etc/contrail/ssl/certs/server.pem
# xmpp_server_key=/etc/contrail/ssl/private/server-privkey.pem
# xmpp_ca_cert=/etc/contrail/ssl/certs/ca-cert.pem

# Sandesh send rate limit can be used to throttle system logs transmitted per
# second. System logs are dropped if the sending rate is exceeded
Expand Down
8 changes: 8 additions & 0 deletions src/dns/test/dns_options_test.cc
Expand Up @@ -237,6 +237,10 @@ TEST_F(OptionsTest, CustomConfigFile) {
"test_mode=1\n"
"log_property_file=log4cplus.prop\n"
"sandesh_send_rate_limit=5\n"
"xmpp_dns_auth_enable=1\n"
"xmpp_server_cert=/etc/server.pem\n"
"xmpp_server_key=/etc/server-privkey.pem\n"
"xmpp_ca_cert=/etc/ca-cert.pem\n"
"\n"
"[DISCOVERY]\n"
"port=100\n"
Expand Down Expand Up @@ -296,6 +300,10 @@ TEST_F(OptionsTest, CustomConfigFile) {
EXPECT_EQ(options_.ifmap_certs_store(), "test-store");
EXPECT_EQ(options_.test_mode(), true);
EXPECT_EQ(options_.sandesh_send_rate_limit(), 5);
EXPECT_EQ(options_.xmpp_auth_enabled(), true);
EXPECT_EQ(options_.xmpp_server_cert(), "/etc/server.pem");
EXPECT_EQ(options_.xmpp_server_key(), "/etc/server-privkey.pem");
EXPECT_EQ(options_.xmpp_ca_cert(), "/etc/ca-cert.pem");
std::remove("./dns_options_test_config_file.conf");
}

Expand Down
7 changes: 7 additions & 0 deletions src/vnsw/agent/contrail-vrouter-agent.conf
Expand Up @@ -64,6 +64,13 @@ log_local=1
# second. System logs are dropped if the sending rate is exceeded
# sandesh_send_rate_limit=100

# Enable/Disable SSL based XMPP Authentication
# xmpp_auth_enable=false
# xmpp_dns_auth_enable=false
# xmpp_server_cert=/etc/contrail/ssl/certs/server.pem
# xmpp_server_key=/etc/contrail/ssl/private/server-privkey.pem
# xmpp_ca_cert=/etc/contrail/ssl/certs/ca-cert.pem

[DISCOVERY]
#If DEFAULT.collectors and/or CONTROL-NODE and/or DNS is not specified this
#section is mandatory. Else this section is optional
Expand Down

0 comments on commit 474e678

Please sign in to comment.