Skip to content

Commit

Permalink
Increase open timer for Bgp/Xmpp state machine used in tests
Browse files Browse the repository at this point in the history
Xmpp server state machine starts the open timer after receiving passive
open and closes the session if it doesn't get an open message before it
expires.

Bgp state machine starts the open timer after receiving passive open in
order to implement a delayed open on the passive side.  This should not
be required in normal cases if the active side sends an open right away.

Hence there's no need to use very small values for the open timer during
integration tests.

Change-Id: I32ab7931342dfbefd2266116377b98699702d8dc
Partial-Bug: 1464016
  • Loading branch information
Nischal Sheth committed Jun 12, 2015
1 parent bedc1ef commit 1da66de
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/bgp/test/bgp_server_test_util.h
Expand Up @@ -137,7 +137,7 @@ class StateMachineTest : public StateMachine {
}

void StartOpenTimer(int seconds) {
open_timer_->Start(10,
open_timer_->Start(1000,
boost::bind(&StateMachine::OpenTimerExpired, this),
boost::bind(&StateMachine::TimerErrorHanlder, this, _1, _2));
}
Expand Down Expand Up @@ -300,7 +300,7 @@ class XmppStateMachineTest : public XmppStateMachine {
}

void StartOpenTimer(int seconds) {
open_timer_->Start(10,
open_timer_->Start(1000,
boost::bind(&XmppStateMachine::OpenTimerExpired, this),
boost::bind(&XmppStateMachine::TimerErrorHandler, this, _1, _2));
}
Expand Down

0 comments on commit 1da66de

Please sign in to comment.