Skip to content

Commit

Permalink
Fix coverage build error
Browse files Browse the repository at this point in the history
No need to run coverage on flaky tests suite, if it is empty

Change-Id: Ib63f52f84478d79221ee67d6e3f76ab976c71d3a
Partial-Bug: 1596630
  • Loading branch information
ananth-at-camphor-networks committed Sep 13, 2016
1 parent 12cadc7 commit 09aa771
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions src/io/test/SConscript
Expand Up @@ -124,13 +124,14 @@ else:
env.AlwaysBuild(run_coverage_cmd)
env.Alias('controller/src/io:test', run_coverage_cmd)

flaky_test = env.TestSuite('io-flaky-test', flaky_test_suite)
clean_coverage_cmd = env.Command('clean_coverage', '', clean_coverage)
env.Depends(flaky_test, clean_coverage_cmd[0].name)
env.AlwaysBuild(clean_coverage_cmd)
run_coverage_cmd = env.Command('run_coverage', '', run_coverage)
env.Depends(run_coverage_cmd, flaky_test[0])
env.AlwaysBuild(run_coverage_cmd)
env.Alias('controller/src/io:flaky-test', run_coverage_cmd)
if len(flaky_test_suite) != 0:
flaky_test = env.TestSuite('io-flaky-test', flaky_test_suite)
clean_coverage_cmd = env.Command('clean_coverage', '', clean_coverage)
env.Depends(flaky_test, clean_coverage_cmd[0].name)
env.AlwaysBuild(clean_coverage_cmd)
run_coverage_cmd = env.Command('run_coverage', '', run_coverage)
env.Depends(run_coverage_cmd, flaky_test[0])
env.AlwaysBuild(run_coverage_cmd)
env.Alias('controller/src/io:flaky-test', run_coverage_cmd)

Return('test_suite')

0 comments on commit 09aa771

Please sign in to comment.