Skip to content

Commit

Permalink
Merge pull request #261 from Juniper/feat/260-superspine-ipv6-loopback
Browse files Browse the repository at this point in the history
Introduce `ResourceGroupNameSuperspineIp6` iota type and related bits
  • Loading branch information
chrismarget-j committed Apr 22, 2024
2 parents cd2b668 + 0a0f755 commit 497c16d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
8 changes: 8 additions & 0 deletions apstra/two_stage_l3_clos_resources.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ const (
ResourceGroupNameAccessAsn
ResourceGroupNameGenericAsn
ResourceGroupNameSuperspineIp4
ResourceGroupNameSuperspineIp6
ResourceGroupNameSpineIp4
ResourceGroupNameSpineIp6
ResourceGroupNameLeafIp4
Expand Down Expand Up @@ -73,6 +74,7 @@ const (
resourceGroupNameAccessAsn = resourceGroupName("access_asns")
resourceGroupNameGenericAsn = resourceGroupName("generic_asns")
resourceGroupNameSuperspineIp4 = resourceGroupName("superspine_loopback_ips")
resourceGroupNameSuperspineIp6 = resourceGroupName("superspine_loopback_ips_ipv6")
resourceGroupNameSpineIp4 = resourceGroupName("spine_loopback_ips")
resourceGroupNameSpineIp6 = resourceGroupName("spine_loopback_ips_ipv6")
resourceGroupNameLeafIp4 = resourceGroupName("leaf_loopback_ips")
Expand Down Expand Up @@ -131,6 +133,8 @@ func (o *ResourceGroupName) Type() ResourceType {
return ResourceTypeAsnPool
case ResourceGroupNameSuperspineIp4:
return ResourceTypeIp4Pool
case ResourceGroupNameSuperspineIp6:
return ResourceTypeIp6Pool
case ResourceGroupNameSpineIp4:
return ResourceTypeIp4Pool
case ResourceGroupNameSpineIp6:
Expand Down Expand Up @@ -211,6 +215,8 @@ func (o ResourceGroupName) raw() resourceGroupName {
return resourceGroupNameGenericAsn
case ResourceGroupNameSuperspineIp4:
return resourceGroupNameSuperspineIp4
case ResourceGroupNameSuperspineIp6:
return resourceGroupNameSuperspineIp6
case ResourceGroupNameSpineIp4:
return resourceGroupNameSpineIp4
case ResourceGroupNameSpineIp6:
Expand Down Expand Up @@ -278,6 +284,8 @@ func (o resourceGroupName) parse() (int, error) {
return int(ResourceGroupNameGenericAsn), nil
case resourceGroupNameSuperspineIp4:
return int(ResourceGroupNameSuperspineIp4), nil
case resourceGroupNameSuperspineIp6:
return int(ResourceGroupNameSuperspineIp6), nil
case resourceGroupNameSpineIp4:
return int(ResourceGroupNameSpineIp4), nil
case resourceGroupNameSpineIp6:
Expand Down
3 changes: 2 additions & 1 deletion apstra/two_stage_l3_clos_resources_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ func TestSetGetResourceAllocation(t *testing.T) {

func TestAllResourceGroupNames(t *testing.T) {
all := AllResourceGroupNames()
expected := 29
expected := 30
if len(all) != expected {
t.Fatalf("expected %d resource group names, got %d", expected, len(all))
}
Expand Down Expand Up @@ -139,6 +139,7 @@ func TestTwoStageL3ClosResourceStrings(t *testing.T) {
{stringVal: "access_asns", intType: ResourceGroupNameAccessAsn, stringType: resourceGroupNameAccessAsn},
{stringVal: "generic_asns", intType: ResourceGroupNameGenericAsn, stringType: resourceGroupNameGenericAsn},
{stringVal: "superspine_loopback_ips", intType: ResourceGroupNameSuperspineIp4, stringType: resourceGroupNameSuperspineIp4},
{stringVal: "superspine_loopback_ips_ipv6", intType: ResourceGroupNameSuperspineIp6, stringType: resourceGroupNameSuperspineIp6},
{stringVal: "spine_loopback_ips", intType: ResourceGroupNameSpineIp4, stringType: resourceGroupNameSpineIp4},
{stringVal: "spine_loopback_ips_ipv6", intType: ResourceGroupNameSpineIp6, stringType: resourceGroupNameSpineIp6},
{stringVal: "leaf_loopback_ips", intType: ResourceGroupNameLeafIp4, stringType: resourceGroupNameLeafIp4},
Expand Down

0 comments on commit 497c16d

Please sign in to comment.