Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement rpc timeout #641

Closed
wants to merge 4 commits into from
Closed

Conversation

apurvaraghu
Copy link
Contributor

fix issue #607

@apurvaraghu apurvaraghu changed the title implement rpm timeout implement rpc timeout Feb 13, 2024
@n3wtype
Copy link

n3wtype commented Apr 18, 2024

I just investigated this issue. It seems that timeout behaviour of commit_confirmed got broken with this commit: 0cdae0e .

It introduced timeout param for commit_confirmed with default value of 30.

However, the only place where commit_configuration is called is

junos_module.commit_configuration(ignore_warning=ignore_warning,
and timeout parameter is not passed here, so default value is always used.

I think more proper solution would be to pass "timeout" parameter to this call if it was passed to module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants