Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unicode: assume foldable ccall in category_code #54394

Merged
merged 1 commit into from
May 8, 2024
Merged

Unicode: assume foldable ccall in category_code #54394

merged 1 commit into from
May 8, 2024

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented May 7, 2024 •
edited

Following on from #54346, this marks the ccall in category_code as foldable. This lets us compute the results of several functions at compile time, such as:

julia> @code_typed (() -> isletter('C'))()
CodeInfo(
1 ─     return true
) => Bool

julia> @code_typed (() -> isnumeric('C'))()
CodeInfo(
1 ─     return false
) => Bool

julia> @code_typed (() -> ispunct('C'))()
CodeInfo(
1 ─     return false
) => Bool

@jishnub jishnub added the compiler:effects effect analysis label May 7, 2024
@topolarity topolarity added the status:merge me PR is reviewed. Merge when all tests are passing label May 8, 2024
@aviatesk aviatesk merged commit 999dde7 into master May 8, 2024
10 checks passed
@aviatesk aviatesk deleted the jishnub/category_code_foldable branch May 8, 2024 04:10
@oscardssmith oscardssmith removed the status:merge me PR is reviewed. Merge when all tests are passing label May 8, 2024
xlxs4 pushed a commit to xlxs4/julia that referenced this pull request May 9, 2024
@jishnub @xlxs4
Unicode: assume foldable ccall in category_code (JuliaLang#54394)
f531707 
Following on from JuliaLang#54346, this
marks the `ccall` in `category_code` as foldable. This lets us compute
the results of several functions at compile time, such as:
```julia
julia> @code_typed (() -> isletter('C'))()
CodeInfo(
1 ─     return true
) => Bool

julia> @code_typed (() -> isnumeric('C'))()
CodeInfo(
1 ─     return false
) => Bool

julia> @code_typed (() -> ispunct('C'))()
CodeInfo(
1 ─     return false
) => Bool
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
compiler:effects effect analysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jishnub @Keno @oscardssmith @aviatesk @topolarity