Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when rounding large numbers to floating point types #54314

Merged
merged 7 commits into from
May 16, 2024
Merged

Fix bug when rounding large numbers to floating point types #54314

merged 7 commits into from
May 16, 2024

Commits on Apr 30, 2024

  1. fix #52355 using option 4 (round to nearest representable integer)

    @LilithHafner
    LilithHafner committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3f14658 View commit details
    Browse the repository at this point in the history

  2. update docstrings

    @LilithHafner
    LilithHafner committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b585310 View commit details
    Browse the repository at this point in the history

  3. add some assorted tests

    @LilithHafner
    LilithHafner committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    227061a View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: mikmoore <95002244+mikmoore@users.noreply.github.com>
    @LilithHafner @mikmoore
    LilithHafner and mikmoore committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    04bec37 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. fix ambiguities

    @LilithHafner
    LilithHafner committed May 9, 2024
    Configuration menu
    Copy the full SHA
    491c11b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into lh/round-to-float

    @LilithHafner
    LilithHafner committed May 9, 2024
    Configuration menu
    Copy the full SHA
    504ae9e View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Fix typo in tests

    @LilithHafner
    LilithHafner committed May 15, 2024
    Configuration menu
    Copy the full SHA
    919abfd View commit details
    Browse the repository at this point in the history