Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL: fix hinting without expanding user #54311

Merged
merged 1 commit into from May 6, 2024

Conversation

IanButterworth
Copy link
Sponsor Member

@IanButterworth IanButterworth commented Apr 30, 2024

Fixes #53884

Hints will show without expanding ~, then a tab will complete the shown hint, then a second tab on the resulting valid path expands ~. I think it makes sense?

Screen.Recording.2024-04-29.at.9.54.40.PM.mov

@IanButterworth IanButterworth added stdlib:REPL Julia's REPL (Read Eval Print Loop) backport 1.11 Change should be backported to release-1.11 labels Apr 30, 2024
@tecosaur
Copy link
Contributor

This looks like a nice change to me 😃

@IanButterworth IanButterworth force-pushed the ib/hint_expanduser branch 3 times, most recently from 6eaed21 to f83b552 Compare April 30, 2024 17:54
@IanButterworth
Copy link
Sponsor Member Author

IanButterworth commented Apr 30, 2024

This is going to require adding the hint kw to Pkg's complete_line. It makes me wonder whether there's a nonbreaking way to inform the system that we're generating a hint (so that different behavior might be given)

JuliaLang/Pkg.jl#3886

@IanButterworth
Copy link
Sponsor Member Author

I found a little weird behavior but it exists before this PR.

GitHub is the only path completion available, yet it doesn't show as a hint until there are 2 chars.

Screenshot 2024-05-06 at 1 00 39 PM
Screenshot 2024-05-06 at 1 00 46 PM
Screenshot 2024-05-06 at 1 02 12 PM

That can be for another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.11 Change should be backported to release-1.11 stdlib:REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REPL: path completion hints shouldn't expand ~ to user dir
2 participants