New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix circshift(::Tuple{}, ::Int)
#54295
Open
nsajko
wants to merge
9
commits into
JuliaLang:master
Choose a base branch
from
nsajko:empty_tuple_circshift
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsajko
added
kind:bugfix
This change fixes an existing bug
domain:collections
Data structures holding multiple items, e.g. sets
performance
Must go faster
labels
Apr 28, 2024
is a bit faster on my machine than the length-2 implementation added here (just |
I think |
ping |
Fixes `circshift` for empty tuples. Fixes JuliaLang#54294
nsajko
force-pushed
the
empty_tuple_circshift
branch
from
May 14, 2024 13:38
fecd485
to
7c7e83d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
domain:collections
Data structures holding multiple items, e.g. sets
kind:bugfix
This change fixes an existing bug
performance
Must go faster
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
circshift
for empty tuples.Fixes #54294