Only initialize libgit2's atexit once
#54254
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation registers multiple `atexit` handlers because the `git_libgit2_init` `ccall` returns the number of inits that have happened. So, every time we run `ensure_initialized` (which is frequent), we register a new, unnecessary handler.
inkydragon
added
libgit2
|
Hmm, how is it possible to hit this? I would have expected that we don't hit |
|
Right, I was not entirely clear in my comment that this is mostly due to static analysis tools being unable to reason about this. "Simplify" should have been the operational word. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation registers multiple
atexithandlers because the
git_libgit2_initccallreturnsthe number of inits that have happened. So,
every time we run
ensure_initialized(which is frequent),we register a new, unnecessary handler.