Propagate sysimage_build_args to run_precompilation_script #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #569 +/- ##
=======================================
Coverage 83.22% 83.22%
=======================================
Files 2 2
Lines 459 459
=======================================
Hits 382 382
Misses 77 77
Continue to review full report at Codecov.
|
|
Also, perhaps update the docstrings that mention this? |
KristofferC
reviewed
Sep 30, 2021
| - `sysimage_build_args::Cmd`: A set of command line options that is used in the Julia process building the sysimage, | ||
| for example `-O1 --check-bounds=yes`. | ||
| - `sysimage_build_args::Cmd`: A set of command line options that is used by both the Julia process running the | ||
| precompilation script and the Julia process building the sysimage, for example `-t2 -O1 --check-bounds=yes`. |
There was a problem hiding this comment.
Unfortunately, the description for this keyword argument exists in two other places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows julia args to be set during the precompilation phase