Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for nightly #2240

Merged
merged 7 commits into from
Jan 17, 2024
Merged

Fixes for nightly #2240

merged 7 commits into from
Jan 17, 2024

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jan 16, 2024

Lots of Memory-related things.


Still unfixed: JuliaLang/julia#52938

MWEs for that issue (in descending order of abstraction):

using CUDA

inner() = nothing

function outer()
    s = CuDeviceStream()
    @cuda dynamic=true stream=s shmem=1 inner()
    return
end

using InteractiveUtils
function main()
    InteractiveUtils.code_llvm(outer, Tuple{})
    CUDA.code_llvm(outer, Tuple{})
end
isinteractive() || main()
using CUDA

inner(a, b, c, d, e, f, h) = nothing

function outer()
    @cuda dynamic=true inner(1, 1, 1, 1, 1, 1, 1)
    return
end

using InteractiveUtils
function main()
    InteractiveUtils.code_llvm(outer, Tuple{})
    CUDA.code_llvm(outer, Tuple{})
end
isinteractive() || main()
using CUDA

cudacall(f, types::Type, args...; kwargs...) = nothing

function outer(f)
    @inline cudacall(f, Tuple{}; stream=Ref(42), shmem=1)
    return
end

using InteractiveUtils
function main()
    InteractiveUtils.code_llvm(outer, Tuple{Nothing})
    CUDA.code_llvm(outer, Tuple{Nothing})
end
isinteractive() || main()

@maleadt maleadt changed the title WIP: Fixes for nightly Fixes for nightly Jan 17, 2024
@maleadt maleadt marked this pull request as ready for review January 17, 2024 13:04
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a152355) 71.47% compared to head (429b34c) 60.37%.
Report is 2 commits behind head on master.

Files Patch % Lines
lib/cudadrv/module/linker.jl 87.50% 1 Missing ⚠️
src/compiler/execution.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2240       +/-   ##
===========================================
- Coverage   71.47%   60.37%   -11.11%     
===========================================
  Files         155      155               
  Lines       14655    14479      -176     
===========================================
- Hits        10474     8741     -1733     
- Misses       4181     5738     +1557     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit 57ca963 into master Jan 17, 2024
1 check passed
@maleadt maleadt deleted the tb/nightly branch January 17, 2024 13:21
maleadt added a commit that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant