Abstracted a couple common functions between Julia and Swift #3743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enting some of the methods as well.
So far it only works with comments, but it's absolutely a start.
`CommonPseudoOO.hs` file. Specifically, they both call booleans `Bool`, and they both are not supported by Doxygen (and therefore Doc comments are free to use point-form instead of Doxygen syntax).
doesn't need to be on the main branch.
bmaclach
reviewed
May 18, 2024
code/drasil-gool/lib/GOOL/Drasil/LanguageRenderer/CommonPseudoOO.hs
Outdated
Show resolved
Hide resolved
bmaclach
approved these changes
May 18, 2024
JacquesCarette
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, Julia and Swift both call booleans
Bool, so I moved that naming intoCommonPseudoOO.Second, Julia and Swift are both not supported by Doxygen, so I followed @bmaclach's convention from Swift, using point form for the doc comments instead of backslashes, which are required for Doxygen. Since this is common between Julia and Swift, I extracted this functionality out of Swift and put it into
CommonPseudoOOas well.Also just an FYI, my work on the Julia renderer is on its own branch at https://github.com/JacquesCarette/Drasil/tree/JuliaRenderer. It's still got a long way to go, but it successfully generates an empty Julia file with a doc comment.