Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding blockers to 3rd party services, for cookies #27

Merged
merged 3 commits into from
May 21, 2024
Merged

Conversation

DarthFutuza
Copy link
Member

image

It is the sadness.

This changes elements such as the WidgetBot Discord Newsfeed on the home page to have display none, and only display after the user has agreed to accepting 3rd party cookies. This similarly happens with embedded YouTube videos.

I don't really want to do this if there's a better way, but I can't think of one that doesn't require actually using/storing cookies. It seems sort of legally grey as to whether or not opt-in/notification is required for essential cookies? Think it depends on the country? I'm also unclear about whether or not it is possible to use YouTube embedded videos without also permitting Google free reign. Maybe these are still considered 'essential'? Need some advice.

…pt cookies first. Kinda ugly but is probably the legally safe thing to do. Also reformatted some of the legal policy to flow a little better. Minor css changes to support the changes.
@DarthFutuza DarthFutuza added help wanted Extra attention is needed question Further information is requested labels Mar 27, 2024
…r so they can choose to view it on YouTube directly instead of agreeing to get a cookie
@DarthFutuza
Copy link
Member Author

I'm considering just adding cookies (and a popup to agree to this), maybe its silly to just avoid this. Might produce a separate PR demonstrating what that would be like. However if I do that, might as well go all the way and start caching more things like the images.

@DarthFutuza
Copy link
Member Author

I think that for now, we will not use cookies/cache as we have too little control over that stuff while using Github as our host. When the site gets upgraded to require server side code (for the launcher and other features such as the databank and logins), we'll add cookies at that point and change our policies to match. On the plus side the Discord widgetbot is pretty slow so this will also make the home page load more quickly since that can be deferred until the user gives permission.

@DarthFutuza DarthFutuza merged commit 0d82a9b into master May 21, 2024
@DarthFutuza DarthFutuza deleted the cookies branch May 21, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant