Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shared] add con_timestamps 2 to disable timestamps in the notify lines only #1216

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Shared] add con_timestamps 2 to disable timestamps in the notify lines only #1216

wants to merge 2 commits into from

Conversation

Razish
Copy link
Member

@Razish Razish commented Feb 26, 2024

No description provided.

@Razish Razish requested a review from a team as a code owner February 26, 2024 15:44
Razish
Razish commented Feb 26, 2024
View reviewed changes
code/client/cl_console.cpp
text += CON_TIMESTAMP_LEN;
lineLimit -= CON_TIMESTAMP_LEN;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, if there are multiple notify lines it will start printing the timestamp from line 2 at the end of line 1 🤦

bartrpe
bartrpe approved these changes Mar 5, 2024
View reviewed changes
Copy link

@bartrpe bartrpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplest code ever, it's so simple even I can say everything is correct, there's nothing that could go wrong with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SomaZ SomaZ SomaZ approved these changes

@bartrpe bartrpe bartrpe approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
A - Client A - Engine T - Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Razish @SomaZ @bartrpe