rend2 - fixed out-of-bounds crash with weather #1190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paishoexpert
changed the title
Charlese2
reviewed
Nov 22, 2023
codemp/rd-rend2/tr_weather.cpp
Outdated
| @@ -1143,6 +1143,11 @@ void RB_SurfaceWeather( srfWeather_t *surf ) | |||
| { | |||
| chunkIndex = (int(centerZoneOffsetX + numMinZonesX) + x + 1) % 3; | |||
| chunkIndex += (int(centerZoneOffsetY + numMinZonesY) + y + 1) % 3 * 3; | |||
|
|
|||
| if (chunkIndex < 0) { | |||
| chunkIndex *= -1; | |||
There was a problem hiding this comment.
Because the % operator in C++ uses truncated division just flipping the sign won't lead to a continuous remainder.
With just flipping the sign, it causes clumping of the rain in the shader.
There was a problem hiding this comment.
Oh, yeah! You are right. I flew around and I didn't spot that issue on vjun1, but it's obvious on your screenshot.
I am not a math crack sadly, but offsetting negative indices with += array-size should theoretically work better shouldn't it?
There was a problem hiding this comment.
I do not know if flipping the sign is actually the best fix all together either, but I could be wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #1189
The game will crash, if a map features weather (e.g. vjun1) and you noclip far enough beneath the map.
This was caused by an out-of-bounds exception caused by chunkIndex sometimes being negative.