Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CODEOWNERS #1168

Merged
merged 1 commit into from
Sep 29, 2023
Merged

add CODEOWNERS #1168

merged 1 commit into from
Sep 29, 2023

Conversation

Razish
Copy link
Member

@Razish Razish commented Sep 22, 2023

Does what it says on the tin.
May want to expand this in future for delegating maintenance (e.g. renderers).

@Razish Razish requested a review from a team September 22, 2023 10:28
bartrpe
bartrpe approved these changes Sep 27, 2023
View reviewed changes
Copy link

@bartrpe bartrpe left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well this is either valid or invalid and the specified team exists so it is valid lol. And the idea itself is pretty much a must-have in project of this scope imho.

Daggolin
Daggolin approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@Daggolin Daggolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering the recent changes to the repository (requiring reviews) and the plan to merge rend2 soon this could be interesting if it gets updated accordingly.

Are there any plans for assigning more sections (other than renderers) anytime soon?

@Razish
Copy link
Member Author

Razish commented Sep 28, 2023 •
edited

Are there any plans for assigning more sections (other than renderers) anytime soon?

No concrete plans, just setting us up so we can

@Razish Razish merged commit 05a1e5e into master Sep 29, 2023
26 checks passed
@Razish Razish deleted the add-codeowners branch September 29, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ensiform ensiform ensiform approved these changes

@Daggolin Daggolin Daggolin approved these changes

@bartrpe bartrpe bartrpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Razish @ensiform @Daggolin @bartrpe