Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gsl-lite #1154

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Update gsl-lite #1154

merged 1 commit into from
Sep 29, 2023

Conversation

cagelight
Copy link
Contributor

The ancient version of gsl-lite currently on the repo does not compile on modern setups, so I have updated the gsl-lite file and taken care of all of the things that have been renamed since the older file. Seemed like just a mass find/replace operation more or less.

@MichaelColonel
Copy link

I've tested this PR on Linux, both Outcast and Academy single player, Release build with gcc-13.2. No problems with compilation and execution.

Before this PR most of gsl-lite errors on Linux ,in my case, were because of undefined std namespace within gsl namespace.

Simple fix for me was to replace std:: to ::std::.
For example:
std::reverse_iterator< iterator > reverse_iterator; -> ::std::reverse_iterator< iterator > reverse_iterator;

Copy link

@bartrpe bartrpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a test on Debian 12.1 with the newest GCC version and didn't encounter any errors building.

Copy link
Contributor

@Daggolin Daggolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a test on Debian 12.1 with the newest GCC version and didn't encounter any errors building.

As far as I know Debian 12 is still on gcc 12. Using gcc12 works for me on the current master branch. Using gcc13 or clang16 did not. With this pull request they work as well.

The sha256sum of lib/gsl-lite/include/gsl/gsl-lite.h matches the current https://raw.githubusercontent.com/gsl-lite/gsl-lite/master/include/gsl/gsl-lite.hpp, so it seems to still be the latest version.

Seems like most of the changes replace cstring_view with cstring_span, because cstring_view seems to have been renamed to cstring_span back in 2015.

@Razish Razish merged commit 4e5fc65 into JACoders:master Sep 29, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants