Fixed some warnings #1116
Open
Fixed some warnings #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikopysov
reviewed
May 11, 2022
| @@ -2904,8 +2904,8 @@ qboolean G_CheckClampUcmd( gentity_t *ent, usercmd_t *ucmd ) | |||
| damage = Q_irand( 3, 5 ); | |||
| } | |||
| } | |||
| if ( ent->client->ps.legsAnimTimer <= 1150 | |||
| && ent->client->ps.legsAnimTimer > 10500 ) | |||
| if ( ent->client->ps.legsAnimTimer > 1150 | |||
There was a problem hiding this comment.
It seems this conflicts with #1119. I'm not sure which one is correct
There was a problem hiding this comment.
If you look at the other checks in the same function you will see that most are checking for a 100ms time window such as:
if ( ent->client->ps.legsAnimTimer <= 3150
&& ent->client->ps.legsAnimTimer > 3050 )
or
if ( ent->client->ps.legsAnimTimer <= 5700
&& ent->client->ps.legsAnimTimer > 5600 )
which is why I assumed mine would be the logical fix here. I could also be wrong though.
There was a problem hiding this comment.
As far as I'm concerned, @tobhe 's one is correct
bartrpe
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.