Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed possible undefined behaviour #1095

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed possible undefined behaviour #1095

wants to merge 1 commit into from

Conversation

j-horner
Copy link
Contributor

@j-horner j-horner commented Jun 9, 2021

Similiar to that in 92059a6

@Razish
Copy link
Member

Razish commented Sep 23, 2023

Can this be rebased on top of master for the automated builds to run? I'm suspect of this working on MSVC.
If it works fine, it's a 👍 from me

bartrpe
bartrpe approved these changes Mar 5, 2024
View reviewed changes
Copy link

@bartrpe bartrpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Razish it actually builds on MSVC, I just tested on whatever is the newest MSVC version built into Visual Studio Enterprise 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartrpe bartrpe bartrpe approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@j-horner @Razish @bartrpe