Fix issue 3195

[luispacheco-dev]

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

• The PR is submitted to the main branch.
• I've read the Contribution Guidelines and my PR doesn't break the rules.
• I've read and understand the Developer Guidelines.
• I confirm that I've run the code locally and everything works as expected.
• 🎬 I've attached a screen recoding of the changes.

Screen_recording_20240517_161255.mov

Discussion

• The "Exchange Rate" screen doesn't use the same data source as the other screens.
• A solution (used it in this draft) is to add the "ExchangeRatesRepo" to the screens that use the CurrencyModal.
• But the exchange rates added to "Exchange Rate" screen doesn't have all the attributes that have IvyCurrency (e.g. name).
• Then in the list this exchange rates are going to show without a name (Video).
• And when the new Currency is set as Base Currency the balance go to zero (it needs the inverse exchange rate to work).
• Also the inverse exchange rate creates duplicate if the currency exist.

Before continue for this path I want to ask your opinion @ILIYANGERMANOV , this is the better way to do it?.

I think maybe the Exchange Rate screen need to be re-write or we need to create a Currency screen.

Does this PR closes any GitHub Issues?

Check Ivy Wallet Issues.

• Closes Exchange rates unavailable in wallet #3195

Replace ISSUE_NUMBER with the number of the GitHub issue that this PR is fixing. If you've done that correctly, you'll see the issue title linked when previewing your PR description.

!Note: Do not link the PR number. Link the number/id of the GitHub Issue from issues.

Troubleshooting CI failures ❌

GitHub Actions failing? Read our CI Troubleshooting guide.

[ILIYANGERMANOV]

Idk, I don't have much context on that. Here's my understanding:

• Deprecate IvyCurrency
• Create a AvailableCurrenciesUseCase
• Make the CurrencyPicker accept a pre-computed currencies list

I'm not sure about the best path, what you did seems fine. You must handle the same for the account creation flow. If you think that it doesn't break anything we can merge it

[ILIYANGERMANOV]

This must be ImmutableList from kotlinx collections

[ILIYANGERMANOV]

Ideally, the entire currency list (standard + manual) should come from the VM and not he computed in the UI. Also, your fix will work for Settings but not for the account creation flow