Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake updates #351

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Cmake updates #351

wants to merge 16 commits into from

Conversation

winterheart
Copy link
Contributor

This PR adds numerous fixes and features to CMake project.

  • Removed feature summary (that was bad idea since it cannot show correctly enabled/disabled options)
  • Fluidsynth-lite and GLEW now statically compiles into executable.
  • Fluidsynth-lite is now bundable into source code via FetchContent, cmake version requirement updated to 3.11 due this.
  • Added optional flag to enable/disable console output on MinGW (default is ON).
  • Updated travis and appveyor CI pipelines to reflect that.
  • Updated documentation.

-g option should not be presented here; if you want to produce Debug binaries, you should use -DCMAKE_BUILD_TYPE="Debug" on cmake invocation.
Dependencies can be installed from system repositories, so there no need own external dependency management.
Appears that pretty useless function.
Previous command was not worked correctly on some cases, for example on cloned repo (without tags).
Unify matrix into 4 standard jobs + 1 custom for 32 bit
Creating matrix for i686 and x86_64 based on MSYS2/MINGW32 environment.
Currently some errors cannot be diagnosed without LOG traces in debug console. -mwindows option suppresses that console, so there we make it optional.
To enable/disable console, pass -DENABLE_WIN_CONSOLE=ON/OFF (default is ON) in configuration phase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant