Ref: height limit check

[RedstoneFuture]

Overview

• The notifyIfOutsideBuildArea method checks the limits and already includes sending the height.height_limit message. This does not need to be called again in the code.
• Small reformatting

Description

In my test, the message was sent correctly even after the refactoring (min_height: 1; max_height: 256).

Submitter Checklist

Edit tasklist title

Beta Give feedback Tasklist Submitter Checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.

   Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Ensure that the pull request title represents the desired changelog entry.

   Ensure that the pull request title represents the desired changelog entry.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. New public fields and methods are annotated with `@since TODO`.

   New public fields and methods are annotated with @since TODO.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

   I read and followed the contribution guidelines.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Submitter Checklist

[RedstoneFuture]

Duplicated message sending: already included in notifyIfOutsideBuildArea()

[RedstoneFuture]

Duplicated message sending: already included in notifyIfOutsideBuildArea()

[RedstoneFuture]

The check in line 1227 looks exactly like the check in notifyIfOutsideBuildArea().

Line 1227:

currentLocation.getY() >= area.getMaxBuildHeight() || currentLocation.getY() < area.getMinBuildHeight()

/Core/src/main/java/com/plotsquared/core/plot/PlotArea.java#L676-L677:

    public boolean notifyIfOutsideBuildArea(PlotPlayer<?> player, int y) {
        if (!buildRangeContainsY(y) && !player.hasPermission(Permission.PERMISSION_ADMIN_BUILD_HEIGHT_LIMIT)) {
            ...
            // Return true if "failed" as the method will always be inverted otherwise
            return true;
        }
        return false;
    }

[NotMyFault]

• What went wrong:
  Execution failed for task ':plotsquared-bukkit:spotlessJavaCheck'.
  The following files had format violations:
  src/main/java/com/plotsquared/bukkit/listener/BlockEventListener.java
  @@ -60,7 +60,6 @@
  import·com.sk89q.worldedit.WorldEdit;
  import·com.sk89q.worldedit.bukkit.BukkitAdapter;
  import·com.sk89q.worldedit.world.block.BlockType;
  -import·net.kyori.adventure.text.Component;
  import·net.kyori.adventure.text.minimessage.tag.Tag;
  import·net.kyori.adventure.text.minimessage.tag.resolver.TagResolver;
  import·org.bukkit.Bukkit;
  Run './gradlew :plotsquared-bukkit:spotlessApply' to fix these violations.