Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Replaced comments above what they describe #4666

Merged
merged 1 commit into from
May 29, 2024

Conversation

andrei-sandor
Copy link
Contributor

COMP: Replaced comments above what they describe

@github-actions github-actions bot added type:Compiler Compiler support or related warnings area:Core Issues affecting the Core module labels May 15, 2024
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most changes look good.

@@ -277,8 +277,13 @@ class ITK_TEMPLATE_EXPORT MapFileParser
GetMemoryUsage(const char * filter, const char * token = "Size");

protected:
std::string m_MapFilePath{}; //< location of the last loaded Map file
TMapData m_MapData{}; //< data of the loaded smap file
/** location of the last loaded Map file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does doxygen generate docs for protected member variables? If not, this change might not make much sense.

@thewtex thewtex merged commit 5d78208 into InsightSoftwareConsortium:master May 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Core Issues affecting the Core module type:Compiler Compiler support or related warnings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants