-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Declare front()
and back()
of Index, Offset, and Size constexpr
#4605
ENH: Declare front()
and back()
of Index, Offset, and Size constexpr
#4605
Conversation
Follow-up to pull request InsightSoftwareConsortium#3236 commit 47bce26 "ENH: Declare begin(), end() of FixedArray, Index, Offset, Size constexpr"
@thewtex Would this PR still be feasible for v5.4.0? It just adds FYI, Adding constexpr to
Which is likely to speed up
|
Out of my curiosity, is this for a particular issue? Has it given any measurable performance benefit? |
This PR would pave the way to adding constexpr to Note that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@N-Dekker this is awesome!
I think we should save it for ITK 6 to avoid any unforeseen issues.
@thewtex OK, thanks. Marked "draft" to avoid that this PR might accidentally be merged before the release of ITK 5.4! |
I think this pull request may also be merged now, as v5.4.0 has been tagged (#4603 (comment)) |
Follow-up to pull request #3236 commit 47bce26
"ENH: Declare begin(), end() of FixedArray, Index, Offset, Size constexpr"