Proposal: Update nuklear_sdl_renderer.h to use recommended path for SDL.h #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change SDL include path to the recommended path
Ryder17z
changed the title
RobLoach
approved these changes
Apr 27, 2024
|
Sounds good to me.
…On Sat, 27 Apr 2024, 21:02 Rob Loach, ***@***.***> wrote:
***@***.**** approved this pull request.
I'm okay with this change, though would like a review from others. The
other thing we could consider is something like...
#ifndef NK_SDL_RENDERER_SDL_H#define NK_SDL_RENDERER_SDL_H <SDL.h>#endif#include NK_SDL_RENDERER_SDL_H
—
Reply to this email directly, view it on GitHub
<#636 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPIOP6BUTKFUNRUBZKPFLTY7PY4ZAVCNFSM6AAAAABG353OL2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRWG4ZDONRWGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
RobLoach
reviewed
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change SDL include path to the recommended path