Add Windows 95/98/ME support to the GDI demo #534
Conversation
|
|
||
| HPEN pen = NULL; | ||
| if (line_thickness == 1) { | ||
| SetDCPenColor(dc, color); |
| ExtTextOutW(dc, x, y, ETO_OPAQUE, NULL, wstr, wsize, NULL); | ||
| } else { | ||
| /* TODO: Convert from UTF-8 to the active code page */ | ||
| ExtTextOutA(dc, x, y, ETO_OPAQUE, NULL, text, len, NULL); |
There was a problem hiding this comment.
Just wondering if you plan to work on this conversion any time soon.
|
Interesting. I am open to merge this as increasing platform compatibility is generally a good idea and the changes do not look harmful to me. Still I wonder what the motivation is as these old systems are super obsolete and I am having hard time imagining anyone targeting them to write new code for. Any insights?
Do you plan to work on it any time soon? Or shall we rather merge this and not wait?
Feel free to consult our wiki in case you missed it: https://github.com/Immediate-Mode-UI/Nuklear/wiki/Complete-font-guide
Could you please add comment(s) to the relevant part(s) of the source code describing how to disable this dependency? Thanks! |
|
Looks like there's a conflict |
This mostly works, with a few caveats:
nk_gdi_rect_multi_colorrequires msimg32.dll which isn't always available. This can be trivially disabled if it's not needed.Screenshot:
