Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MSVC CI #521

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add MSVC CI #521

wants to merge 3 commits into from

Conversation

learn-more
Copy link
Contributor

Both a 'default' build, and with the define INCLUDE_ALL set will be built.
I did not know how to unroll the individual build steps (without making it a huge matrix, where each build will do a new checkout),
so all build steps are copy-pasted manually.

learn-more
learn-more commented Dec 1, 2022
View reviewed changes
.github/workflows/ccpp.yml Outdated
- uses: actions/checkout@v3

- name: Visual Studio shell
uses: egor-tensin/vs-shell@v2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge it yet, I should replace this with ilammy/msvc-dev-cmd instead, since that is more actively used / developed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take your time. Let me know once we should jump on this to review 😉. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dumblob I have updated the builder, so feel free to review it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apt-get seems to have some trouble ...

@dumblob
Copy link
Member

dumblob commented Dec 1, 2022

I did not know how to unroll the individual build steps (without making it a huge matrix, where each build will do a new checkout),
so all build steps are copy-pasted manually.

I think your approach is totally OK - it is explicit and IMHO not that verbose and allows for quick commenting out things etc.

@learn-more
Copy link
Contributor Author

@dumblob is there anything I can do to get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dumblob dumblob dumblob left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@learn-more @dumblob @RobLoach