Addressing #455 (D3D12 Backend) #487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So here we go... tried to fix a bug that was not a bug... found another one and fixed it (Changes to D3D12 regarding resource states on upload heaps)... Added a note for the first bug... |
|
@dumblob can you please take a look at this |
dumblob
reviewed
Mar 29, 2023
| /* | ||
| * === IMPORTATE NOTE FOR D3D12 === | ||
| * | ||
| * Due to a bug in the Windows SDK that |
There was a problem hiding this comment.
Please define/describe shortly the bug in the comment so that it is greppable. Then I will merge. Thanks a lot!
There was a problem hiding this comment.
Oh and maybe squash the commits - it is a small change we could keep together 😉.
- Using ID3D12DescriptorHeap_GetGPUDescriptorHandleForHeapStart now again as intended (I don't know why at some point of time MSFT had this function the way it was used previously...) Revert "Fixed compiler warnings" ... well it had a reason why I did what I did ... This reverts commit 97c7a6b. Fixed a bug with modern directx versions added note for the winsdk issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR on the process of
fixingissue #455Issues with
ID3D12DescriptorHeap_GetCPUDescriptorHandleForHeapStartand a crashing application in D3D12 Backend. Issue will only apear on old versions of the windows SDK