Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fix MultiLayer Image display #5771

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

FrsECM
Copy link

@FrsECM FrsECM commented Apr 23, 2024

PR fulfills these requirements

  • [ x] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • [x ] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • [ x] Frontend

Describe the reason for change

When using multilayered images. Often the gallery is not visible when dealing with large images.

What does this fix?

The fix moves toggle button near the toolbar in order it to be everytime visible.

New behavior :

labelstudio_pdd_example.mp4

What is the new behavior?

The new behavior is very similar to the old one. Just the buttons are in another place and sticky.

What is the current behavior?

In the current behavior, buttons can be hidden and we need to scroll up/down to access it.
By doing so, most of the time we lose buttons in order to select labels what is anoying.

What libraries were added/updated?

None

Does this change affect performance?

It improve labellers performance.

Does this change affect security?

No

What alternative approaches were there?

Display everytime buttons, but if doing so, we'll lose some place for the image.

What feature flags were used to cover this change?

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • [x ] Not sure (briefly explain the situation below)
    For me it's not breaking changes.

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Annotation of multilayer images.

Copy link

netlify bot commented Apr 23, 2024

👷 Deploy request for label-studio-docs-new-theme pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f3b46d1

Copy link

netlify bot commented Apr 23, 2024

👷 Deploy request for heartex-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f3b46d1

@FrsECM FrsECM marked this pull request as ready for review April 23, 2024 12:00
@github-actions github-actions bot added the feat label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant