Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return predictions even in next_task even with empty model_version #5685

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Apr 5, 2024

Fixes two things:

  • any empty version ("" or None) considered falsy
  • if there are no model_version selected we return all predictions to be consistent with old version and GET /task/:id

Connected to LEAP-930 investigations

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 5f92622
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66104b87a6c4e10008acc8f5

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 5f92622
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66104b87503e340008785ebe

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 75.96%. Comparing base (e9f3d8d) to head (5f92622).
Report is 4 commits behind head on develop.

Files Patch % Lines
label_studio/tasks/models.py 50.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5685      +/-   ##
===========================================
+ Coverage    75.93%   75.96%   +0.02%     
===========================================
  Files          158      158              
  Lines        13324    13329       +5     
===========================================
+ Hits         10118    10125       +7     
+ Misses        3206     3204       -2     
Flag Coverage Δ
pytests 75.96% <50.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant