Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis 7.2.5 #172142

Merged
merged 2 commits into from
May 20, 2024
Merged

redis 7.2.5 #172142

merged 2 commits into from
May 20, 2024

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333 chenrui333 added livecheck Issues or PRs related to livecheck CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels May 20, 2024
@chenrui333 chenrui333 requested a review from samford May 20, 2024 13:17
@Bo98
Copy link
Member

Bo98 commented May 20, 2024

Is 7.2.5 not still on the old license?

@samford
Copy link
Member

samford commented May 20, 2024

Is 7.2.5 not still on the old license?

7.2.5 still uses the existing license comments in source files, etc., so upstream's statement that the license changes won't apply until 7.4 appears to be correct.

With that in mind, we can update the existing livecheck block to omit 7.4+ versions for now and update it to use #skip when 7.4 is released.

@carlocab carlocab added the automerge-skip `brew pr-automerge` will skip this pull request label May 20, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue May 20, 2024
@samford samford removed this pull request from the merge queue due to a manual request May 20, 2024
Formula/r/redis.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. and removed automerge-skip `brew pr-automerge` will skip this pull request labels May 20, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label May 20, 2024
@chenrui333 chenrui333 changed the title redis: update livecheck to ignore 7.2.4+ redis 7.2.5 May 20, 2024
@chenrui333
Copy link
Member Author

actually bump to 7.2.5 (somehow I thought they added the license change for this new release)

@chenrui333 chenrui333 removed the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label May 20, 2024
@SMillerDev
Copy link
Member

Maybe we can just make it fail the test too for those versions. Since mismatched livecheck is easy to miss

Signed-off-by: Rui Chen <rui@chenrui.dev>

Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 20, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue May 20, 2024
Merged via the queue into master with commit a30be84 May 20, 2024
14 checks passed
@BrewTestBot BrewTestBot deleted the redis-livecheck branch May 20, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants