Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Intel Arc hardware acceleration support. #982

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Finn2708
Copy link

@Finn2708 Finn2708 commented Apr 4, 2024

This PR addresses #902.

It updates Dockerfile.base to jammy and adds the latest media runtime (and probably some unrequired dependencies).
Unfortunately, I can't test Dockerfile.final, but in Dockerfile.base I can transcode with HandBreakCLI using my Arc A380.

Let me know if I can assist with testing the final build.

@hollanbm
Copy link

This PR addresses #902.

It updates Dockerfile.base to jammy and adds the latest media runtime (and probably some unrequired dependencies). Unfortunately, I can't test Dockerfile.final, but in Dockerfile.base I can transcode with HandBreakCLI using my Arc A380.

Let me know if I can assist with testing the final build.

While I'm generally a fan of all of the changes you made to the Dockerfile, the giant RUN commands make it harder to fully leverage the Docker layers cache.

I would instead open a second PR, with your refactors. It's hard to tell what is required for ARC, versus what isn't. Which could hold up the PR longer than is needed

@HaveAGitGat
Copy link
Owner

@Finn2708 thanks I'll try incorporating these changes.

@hollanbm as far as I'm aware it's better to use fewer RUN commands as each one creates a new layer which can dramatically increase image size depending on what's happening. So yes in development it's faster to use multiple RUN command so the layer cache can be used but not ideal for end image.

@HaveAGitGat
Copy link
Owner

But yes adding the RUN commands and changing the indenting does make it difficult to see exactly what has changed, I'll need to go through line by line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants