Repo issue 1413 #1414
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| using Hangfire.MemoryStorage; | ||
| using System; | ||
| using System.Collections.Concurrent; | ||
| using System.Collections.Generic; | ||
| using System.Threading; | ||
| using Xunit; | ||
|
|
||
| namespace Hangfire.Core.Tests | ||
| { | ||
| public class JobWrapperNotWorking | ||
| { | ||
| private readonly string RecurringJobId = Guid.NewGuid().ToString(); | ||
|
|
||
| public Action Callback { get; set; } | ||
|
|
||
| public void ScheduleAndTrigger() | ||
| { | ||
| RecurringJob.AddOrUpdate(RecurringJobId, () => Invoke(), () => "* * * * *"); | ||
| RecurringJob.Trigger(RecurringJobId); | ||
| Thread.Sleep(1000); | ||
| RecurringJob.RemoveIfExists(RecurringJobId); | ||
| } | ||
|
|
||
| public void Invoke() | ||
| { | ||
| Callback?.Invoke(); | ||
| } | ||
| } | ||
|
|
||
| public class JobWrapperWorking | ||
| { | ||
| private readonly string RecurringJobId = Guid.NewGuid().ToString(); | ||
| private static readonly IDictionary<string, JobWrapperWorking> s_jobId2WrapperMappings = new ConcurrentDictionary<string, JobWrapperWorking>(); | ||
|
|
||
| public Action Callback { get; set; } | ||
|
|
||
| public void ScheduleAndTrigger() | ||
| { | ||
| s_jobId2WrapperMappings[RecurringJobId] = this; | ||
| RecurringJob.AddOrUpdate(RecurringJobId, () => Invoke(RecurringJobId), () => "* * * * *"); | ||
| RecurringJob.Trigger(RecurringJobId); | ||
| Thread.Sleep(1000); | ||
| RecurringJob.RemoveIfExists(RecurringJobId); | ||
| } | ||
|
|
||
| public void Invoke(string jobId) | ||
| { | ||
| var wrapper = s_jobId2WrapperMappings[jobId]; | ||
| wrapper?.Callback?.Invoke(); | ||
| } | ||
| } | ||
|
|
||
| public class RecurringJobWithClassFacts | ||
| { | ||
| static RecurringJobWithClassFacts() | ||
| { | ||
| GlobalConfiguration.Configuration | ||
| .UseMemoryStorage(); | ||
|
|
||
| _ = new BackgroundJobServer(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void CallbackShouldTrigger_NotWorking() | ||
| { | ||
| var job = new JobWrapperNotWorking(); | ||
| bool triggered = false; | ||
| job.Callback = () => { triggered = true; }; | ||
|
|
||
| job.ScheduleAndTrigger(); | ||
|
|
||
| Assert.Equal(false, triggered); | ||
|
|
||
| } | ||
|
|
||
| [Fact] | ||
| public void CallbackShouldTrigger_Working() | ||
| { | ||
| var job = new JobWrapperWorking(); | ||
| bool triggered = false; | ||
| job.Callback = () => { triggered = true; }; | ||
|
There was a problem hiding this comment. while callback is invoked in this case |
||
|
|
||
| job.ScheduleAndTrigger(); | ||
|
|
||
| Assert.Equal(true, triggered); | ||
|
|
||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Callback here is not invoked