-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizing /user/buy/x in 40-50% #14984
base: develop
Are you sure you want to change the base?
Conversation
i will work on that failed check on the weekend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad you found this issue - something we all missed I guess haha, just a few comments there
as for the CI issues - we had an issue with our package-lock.json that just automagically broke all installations hahah, so once you pull the latest develop it should(TM) work again
@negue ready for review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you also pull develop branch into yours? that way our CI's can then do their job 😬 and we can see if something else broke (you never know 😆 )
config.json.example
Outdated
@@ -88,4 +88,5 @@ | |||
"REDIS_PORT": "1234", | |||
"REDIS_PASSWORD": "12345678", | |||
"TRUSTED_DOMAINS": "localhost,habitica.com" | |||
"NO_CLUSTER": "false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove all now not needed changes from the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm sorry, i thought was removed
@negue the npm error in CI/CD continues, what we should do in this case? |
note: the |
yes you need to pull our current develop state into your develop and then push it here - otherwise the old issue we had on develop won't vanish 😬
oh strange, well if the CI allows it afterwards I don't see a problem on it |
@negue I rebased but the ci isn't running, must we trigger it? |
Correct, the CI is not run for new contributors (and maybe all non members? I don't know what rule for that is) so we have to trigger them manually Now whats only left is to have the tests running again 😁 I think all other failed tests just have the same "issue" |
ok, but why it is blocked for nonmembers? i mean, it makes the PR pretty long support neededwell, i need support here, I guess the last broken tests isn't related to my changes but it is affecting it and it could be a bug possible bug descriptionWe have some hardcoded events in ...website/common/script/content/constants/events.js file, that events dont match with the current date, because this, the CURRENT_EVENT is coming empty in ./shops-seasonal.config file, that makes sense, we dont have any event for this month Because this for me, it looks like a bug and it doesn't have a relation with these PR changes my changes related to the possible buganyway, I improved the |
could you run the tests again, please? |
Tests seems to work 🎉 apart from those two which seems to be broken for a while now (gonna take a look at these right now) - but your tests are fine! Thank you for the work! @SabreCat could you take a look at this PR and/or merge it? :) |
@negue do you know another admin to check this PR? |
Thanks for this, @italojs, and welcome to the ranks of the Blacksmiths at tier 1! |
I'm experimenting with some performance monitoring tools on Habitica for my studies, so I found a little unoptimized code
Changes
1
Optimized
website/common/script/libs/getOfficialPinnedItems.js > getOfficialPinnedItems
function, we are using 2 optimizations:set to be added
, will avoid the filter usageIt reduced the endpoint time by ~40%
That values in my local environment, in prod this same endpoint is consuming ~200ms
Unptimized
Optimized
2
Added a flag to avoid using clustering, it helps when we are monitoring the application to tunning stuff
UUID: aa5a278e-675d-4d8f-ae2b-90391b2d7218