Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node start abstraction #19382

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

moesterheld
Copy link
Contributor

@moesterheld moesterheld commented May 17, 2024

Description

Initial draft for creating a common bootstrapping for starting all kinds of nodes.

So far, removes CmdLineTool and replaces it with a AbstractNodeBootstrap which accepts any kind of configuration.
This should be used in combination with the AbstractNodeCommand to configure and start any kind of node with the required bindings and configs.

Work in progress
TODOs:

  • create a common bootstrapping for nodes with preflight (Graylog/data node)
  • change all existing commands to use command abstraction
  • clean up bindings
  • tests
  • remove ExampleCommand and example config

/jpd https://github.com/Graylog2/graylog-plugin-enterprise/pull/7316
/nocl

Motivation and Context

remove duplicate code, provide common startup mechanism #18011 , #18908

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant