feat(export): allow GMP collectors to startup without metadata #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pintohutch
approved these changes
May 17, 2024
|
It also looks like there's some build and test failures as well - maybe a rebase from main will fix things? |
TheSpiritXIII
force-pushed
the
TheSpiritXIII/collector-labels
branch
from
345dedf
to
d2b2224
Compare
TheSpiritXIII
force-pushed
the
TheSpiritXIII/collector-labels
branch
from
d2b2224
to
db1459e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way our e2e tests are written is usually we check for the GMP collector to start-up correctly.
The problem is that if we defer the metadata labeling to the configuration as opposed to flags, then the collector will never start-up correctly (and also goes against our goal which is to prevent the collector from restarting at initialization).
The simple solution here is to defer error handling until we have a configuration with scape or rule configurations.
See also: #965