Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): debug pod logs #976

Merged
merged 1 commit into from
May 24, 2024
Merged

test(e2e): debug pod logs #976

merged 1 commit into from
May 24, 2024

Conversation

TheSpiritXIII
Copy link
Member

@TheSpiritXIII TheSpiritXIII commented May 16, 2024

Show debug Prometheus collector logs when an e2e test fails to startup.

I was running into an issue that only happened on GitHub Actions. How this works:

  1. Use a context that times out right before the test. This ensures the test catches the timeout and can "cleanup" or in this case, show logs before exiting.
  2. Show debug logs in the test. We use a new context in case the test timed out, and the original context cannot be reused.

@TheSpiritXIII TheSpiritXIII marked this pull request as ready for review May 16, 2024 15:49
Copy link
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's try 💪🏽

@bwplotka bwplotka merged commit 8eaae17 into main May 24, 2024
27 checks passed
@TheSpiritXIII TheSpiritXIII deleted the TheSpiritXIII/e2e-debug-log branch May 24, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants