feat: update manifests with new prom image and delete flag #947
+24
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSpiritXIII
approved these changes
Apr 25, 2024
pintohutch
reviewed
Apr 25, 2024
gmp-bot
force-pushed
the
release-please--branches--main
branch
3 times, most recently
from
8884df5
to
adc7e38
Compare
|
Small nit: can we create a proper release/0.12 branch and push into that instead of release-please? I see release-please rebasing the branch and updating this PR. I'm not sure if it would keep changes such as these. Thanks! |
TheSpiritXIII
approved these changes
Apr 29, 2024
bwplotka
force-pushed
the
0.12-go
branch
2 times, most recently
from
a870d71
to
2b3151f
Compare
|
Have to park it until we have Prometheus image on prod. |
|
Updated, using SHA for now, as we can't copy tags. |
TheSpiritXIII
approved these changes
May 23, 2024
Signed-off-by: bwplotka <bwplotka@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted clean state here and what I can import into latest manifest release.