refactor(e2e): move tag copying to Go and use exact tags #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSpiritXIII
force-pushed
the
TheSpiritXIII/e2e-copy-images
branch
3 times, most recently
from
3f13128
to
be240f3
Compare
TheSpiritXIII
force-pushed
the
TheSpiritXIII/e2e-copy-images
branch
2 times, most recently
from
07ef95f
to
e94c56c
Compare
TheSpiritXIII
force-pushed
the
TheSpiritXIII/e2e-copy-images
branch
2 times, most recently
from
5471c74
to
e581ab2
Compare
TheSpiritXIII
force-pushed
the
TheSpiritXIII/e2e-copy-images
branch
from
e581ab2
to
3eda393
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of #852 to fully implement #845
This PR moves copying images to Golang. This makes dealing with conditional logic easier. We now check whether the tagged image exists (e.g. for
make e2e) and if it does not, we use the latest image (e.g. formake e2e-only).The biggest caveat of this change is importing the docker client library, but this library would be utilized more if we move more of the
kind-test.shlogic to Golang (such as setting up the kind cluster network).