Add Anthos MultiCloud distributions to UserAgentMode #465
Conversation
| @@ -50,6 +50,9 @@ const ( | |||
| UAModeUnspecified = "unspecified" | |||
| UAModeAVMW = "on-prem" | |||
| UAModeABM = "baremetal" | |||
| UAModeAWS = "aws" | |||
There was a problem hiding this comment.
We have both a UserAgentMode and UserAgentEnv, where the former is generally reserved for the mode of installation and the latter for the platform environment. Notably, the former is user-modifiable via a flag, whereas the latter is hard-coded into the binary and auto-populated at runtime.
Is there any way to auto-detect whether we're running in AWS or Azure using a go library that we could add to the logic in setup.go?
For on-prem or baremetal, autodetection is not possible due to the heterogeneity of those environments, so using "mode" as a way to distinguish these makes sense, albeit it's getting double-usage out of that flag.
There was a problem hiding this comment.
That's a good point. @ericroman920 could you comment on the auto detection for anthos on aws & azure?
| @@ -50,6 +50,9 @@ const ( | |||
| UAModeUnspecified = "unspecified" | |||
| UAModeAVMW = "on-prem" | |||
There was a problem hiding this comment.
Could you add comments on what each of these modes means? e.g. what's the difference between "on-prem" and "baremetal"?
| @@ -50,6 +50,9 @@ const ( | |||
| UAModeUnspecified = "unspecified" | |||
| UAModeAVMW = "on-prem" | |||
| UAModeABM = "baremetal" | |||
| UAModeAWS = "aws" | |||
| UAModeAzure = "azure" | |||
| UAModeAttached = "attached" | |||
There was a problem hiding this comment.
Attached clusters could be any k8s cluster that customers want to connect to Google.
There was a problem hiding this comment.
Gotcha - could you add a comment?
#433 only added the 2 Anthos Hybrid distributions, this one adds 3 MultiCloud distributions to fully resolve #432.