Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add anthos distributions to the user-agent-mode enum #432

Closed
leonzz opened this issue Feb 26, 2023 · 1 comment · Fixed by #433 · May be fixed by #465
Closed

Add anthos distributions to the user-agent-mode enum #432

leonzz opened this issue Feb 26, 2023 · 1 comment · Fixed by #433 · May be fixed by #465

Comments

@leonzz
Copy link
Contributor

leonzz commented Feb 26, 2023

right now the user-agent-mode has 3 supported values: gke, kubectl, unspecified, ref: https://github.com/GoogleCloudPlatform/prometheus-engine/blob/v0.6.1/pkg/export/setup/setup.go#L134

By adding anthos distributions to the enum (e.g. one additional enum item anthos or further breakdowns like anthos-vmware, anthos-baremetal, anthos-aws, anthos-azure, anthos-attached), we'll be able to further distinguish the traffic coming from different type of clusters.
@leonzz
Copy link
Contributor Author

leonzz commented Feb 26, 2023

Just notices we had the mode for anthos in an earlier version: https://github.com/GoogleCloudPlatform/prometheus-engine/blob/v0.4.3/pkg/operator/operator.go#L237

we need to add back those options to keep backward compatibility.

@leonzz leonzz mentioned this issue Feb 26, 2023
Merged
@leonzz leonzz mentioned this issue Apr 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@leonzz